Ensure requests are not assuming the presence of file paths for entries #3030
+112
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
This stack of pull requests is managed by Graphite. Learn more about stacking. |
andyw8
approved these changes
Jan 9, 2025
Merge activity
|
vinistock
deleted the
01-09-ensure_requests_are_not_assuming_the_presence_of_file_paths_for_entries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One more bug fix to include in the next release 😅. In #2941, we started indexing unsaved files. However, we didn't fix the requests that were assuming the presence of a file path in entries with
T.must.We need to handle the possibility of there not being a file path, so that we can account for entries in unsaved files.
Implementation
Fixed all of the occurrences I could find where we assumed the file path to be there.
Automated Tests
Added tests that reproduce each one of the bugs.